Actually trying to do something techical, part II: HowTo fix a MySQL Cluster bug without touching a single line of code!

hingo's picture

This is part II of my efforts to prove myself that I can do programming. In part one I successfully created a MySQL Cluster branch for myself and compiled it.

Let's go to the public MySQL bug database and see if there are any trivial MySQL Cluster bugs I could sharpen my teeth on. Heh, sure enough #32658 looks simple enough. There is a typo in an output string - so I could fix that without even doing any C++ code! (Funnily, a MySQL internal comment to the bug says something about it being embarrassing. Guess it is a good bug for me then, as patching over embarrasments is what Sales Engineers do routinely :-)

Let me see...


$ # Set my email address so it will be correct if I actually manage to make a patch out of this
$ # Yeah, I never really got around to using the sun.com address. Guess now I will never need to either :-)
$ bzr whoami "Henrik Ingo <henrik.ingo@mysql.com>"
$ bzr branch mysql-cluster-7.0 bug-32658
$ grep -R subscritopn *
(nothing)
$ # Eh, am I using grep correctly?
$ grep -R "Starting dump of subscribers" *
storage/ndb/src/kernel/blocks/suma/Suma.cpp: infoEvent("-- Starting dump of subscribers --");
$ # Yes I am.
$ less storage/ndb/src/kernel/blocks/suma/Suma.cpp

Right. So it seems the bug has been fixed?


ndb_mgm> show
Cluster Configuration
---------------------
[ndbd(NDB)] 2 node(s)
id=2 @127.0.0.1 (mysql-5.1.34 ndb-7.0.7, Nodegroup: 0, Master)
id=3 @127.0.0.1 (mysql-5.1.34 ndb-7.0.7, Nodegroup: 0)
[ndb_mgmd(MGM)] 1 node(s)
id=1 @127.0.0.1 (mysql-5.1.34 ndb-7.0.7)
[mysqld(API)] 1 node(s)
id=7 @127.0.0.1 (mysql-5.1.34 ndb-7.0.7)
ndb_mgm> all dump 8011
Sending dump signal with data:
0x00001f4b Sending dump signal with data:
0x00001f4b
ndb_mgm>
$ tail -f mysql-cluster/ndb_1_cluster.log
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: -- Starting dump of subscribers --
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Table 4 ver 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Subcription 0
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Subscriber [ 80020007 24 0 ]
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Table 4 #subscribers 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Table 5 ver 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Subcription 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Subscriber [ 80020007 28 1 ]
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Table 5 #subscribers 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Table 6 ver 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Subcription 2
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Subscriber [ 80030007 24 2 ]
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: Table 6 #subscribers 1
2009-06-02 12:51:01 [MgmSrvr] INFO -- Node 3: -- Ending dump of subscribers

Yes. Add comment to bug that it is fixed in 7.0.7


$ cd ..
$ rm -Rf bug-32658/

Ok, so I feel a little nerdy already. But I didn't touch any source, this was more like a read-only bug fix :-) Seems like there will be a Part III before I'm satisfied...

Post new comment

The content of this field is kept private and will not be shown publicly.
  • Use [fn]...[/fn] (or <fn>...</fn>) to insert automatically numbered footnotes.
  • Allowed HTML tags: <h1> <h2> <h3> <h4> <p> <a> <em> <strong> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd> <br> <sup> <div> <blockquote> <pre> <img>
  • Lines and paragraphs break automatically.
  • Web page addresses and e-mail addresses turn into links automatically. (Better URL filter.)

CAPTCHA
This question is for testing whether you are a human visitor and to prevent automated spam submissions.
1 + 0 =
Solve this simple math problem and enter the result. E.g. for 1+3, enter 4.